Skip to content

Conversation

@MarcelSchuermann
Copy link
Contributor

Pull Request for Issue #45781

Summary of Changes

404 and 406 exceptions should be handled correctly with useful information and as NOTICE instead of unspecific CRITICAL Error, so the log is not overloaded and unspecific.

Testing Instructions

  1. Set up a standard Joomla 5.x installation.
  2. In Global Configuration -> Logging, enable logging to capture errors.
  3. Navigate to any URL on the frontend that does not exist f.e.:
    yourpage/asdf
  4. Check logs in joomlaroot/administrator/logs
  5. See critical unspecific error

Actual result BEFORE applying this Pull Request

A log entry with 404 or 406 exceptions end up in CRITICAL unspecific / unhandled ERROR log.

2025-07-25T15:17:44+00:00	CRITICAL ::1	error	Uncaught Throwable of type Joomla\CMS\Router\Exception\RouteNotFoundException thrown with message "Seite nicht gefunden". Stack trace: #0 [ROOT]\libraries\src\Application\SiteApplication.php(767): Joomla\CMS\Router\Router->parse(Object(Joomla\CMS\Uri\Uri), true)
#1 [ROOT]\libraries\src\Application\SiteApplication.php(243): Joomla\CMS\Application\SiteApplication->route()
#2 [ROOT]\libraries\src\Application\CMSApplication.php(304): Joomla\CMS\Application\SiteApplication->doExecute()
#3 [ROOT]\includes\app.php(58): Joomla\CMS\Application\CMSApplication->execute()
#4 [ROOT]\index.php(32): require_once('C:\\Web\\xampp\\ht...')
#5 {main}

Expected result AFTER applying this Pull Request

A log entry with a handled NOTICE message including f.e. the page, which was accessed.

2025-10-15T19:43:30+00:00 NOTICE ::1 client-error Page not found (404): http://localhost:8080/yourwebsite/asdfs. Message: "Seite nicht gefunden"

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@MarcelSchuermann
Copy link
Contributor Author

The change worked on my environment.
Can someone test?

@richard67 richard67 added the bug label Oct 24, 2025
@muhme
Copy link
Contributor

muhme commented Oct 24, 2025

I have tested this item ✅ successfully on f416e8f

Tested with JBT, reproduced the problem, which only occurs in using .htaccess, so the following was also needed:
docker exec jbt-54 mv htaccess.txt .htaccess
Seen log message:

2025-10-24T15:03:03+00:00       CRITICAL        57.128.19.244   error   Uncaught Throwable of type Joomla\CMS\Router\Exception\RouteNotFoundException thrown with message "Page not found". ...

Applied the PR with patchtester and seen suitable log message:

2025-10-24T15:12:17+00:00       NOTICE  57.128.19.244   client-error    Page not found (404): http://localhost:7054/bla. Message: "Page not found"

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46296.

@exlemor
Copy link

exlemor commented Oct 31, 2025

I have tested this item ✅ successfully on f416e8f

Hi @MarcelSchuermann, thanks for this nice PR, I was able to successfully test this!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46296.

@muhme muhme removed the bug label Oct 31, 2025
@muhme
Copy link
Contributor

muhme commented Oct 31, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46296.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 31, 2025
@muhme muhme added the bug label Oct 31, 2025
@richard67 richard67 added this to the Joomla! 5.4.1 milestone Oct 31, 2025
@richard67 richard67 merged commit fe62365 into joomla:5.4-dev Oct 31, 2025
60 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 31, 2025
@richard67
Copy link
Member

Thanks @MarcelSchuermann for this PR, and @muhme and @exlemor for testing.

@MarcelSchuermann
Copy link
Contributor Author

Thank you all for helping and @richard67 for merging.
Will this automatically be integrated in 6.x releases as well if needed or how does it work?

@richard67
Copy link
Member

Changes in the 5.4-dev branch will be regularly merged up into the 6.0-dev branch, so this fix will be included in the 5.4.1 and 6.0.1 release scheduled for November 25.

@richard67
Copy link
Member

P.S. And it will also be merged up into 6.1-dev at some time.

@MarcelSchuermann
Copy link
Contributor Author

Ah great, thank you for the info. 🙏😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants