-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[5.x] replace 404 and 406 CRITICAL errors with NOTICE and useful information #46296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.x] replace 404 and 406 CRITICAL errors with NOTICE and useful information #46296
Conversation
|
The change worked on my environment. |
|
I have tested this item ✅ successfully on f416e8f Applied the PR with patchtester and seen suitable log message: This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46296. |
|
I have tested this item ✅ successfully on f416e8f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46296. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46296. |
|
Thanks @MarcelSchuermann for this PR, and @muhme and @exlemor for testing. |
|
Thank you all for helping and @richard67 for merging. |
|
Changes in the 5.4-dev branch will be regularly merged up into the 6.0-dev branch, so this fix will be included in the 5.4.1 and 6.0.1 release scheduled for November 25. |
|
P.S. And it will also be merged up into 6.1-dev at some time. |
|
Ah great, thank you for the info. 🙏😊 |
Pull Request for Issue #45781
Summary of Changes
404 and 406 exceptions should be handled correctly with useful information and as NOTICE instead of unspecific CRITICAL Error, so the log is not overloaded and unspecific.
Testing Instructions
yourpage/asdf
Actual result BEFORE applying this Pull Request
A log entry with 404 or 406 exceptions end up in CRITICAL unspecific / unhandled ERROR log.
Expected result AFTER applying this Pull Request
A log entry with a handled NOTICE message including f.e. the page, which was accessed.
2025-10-15T19:43:30+00:00 NOTICE ::1 client-error Page not found (404): http://localhost:8080/yourwebsite/asdfs. Message: "Seite nicht gefunden"Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed